Open Bug 1588285 Opened 6 years ago Updated 2 years ago

Incorrect wording when using a more recent version of clang-format

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Tracking

(Not tracked)

REOPENED

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

I tried to run clang-format-10 and the message that I get is:
You're using an old version of clang-format binary. Please update to a more recent one by running: './mach bootstrap'

It is because our version comparison is pretty bad:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code-analysis/mach_commands.py#919

We could either:

  • improve the version detection
  • fix the wording to force only one version

I would prefer the second option as we see different output with clang-format when bugs are fixed

can be done in parallel of bug 1588185

Hi there, I want to work on this issue, but as I am a beginner this is new to me. can you pleas guide me on how to proceed? Thanks:)

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sledru)

@prasadsneha2502
sure, just read the doc :)

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(sledru)
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(sledru)
Priority: -- → P3

@sylvestre, Is it required to modify the is_version_eligible function so that the version compares to a hard-coded version?

correct
are you working on it?

Flags: needinfo?(prasadsneha2502)

@Sylvestre I am new to open source so can you please guide me through this ? This seems a little bit overwhelming to open for the first time. Please guide me. Thanks

(In reply to Sylvestre Ledru [:Sylvestre] from comment #6)

correct
are you working on it?

Yes, I just wanted to get confirmed about the approach. Will be submitting the patch in a day or two.

Flags: needinfo?(prasadsneha2502)

@Syvestre i am getting error while building the setup ( ./mach build)
Error running mach:

['build']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: argument of type 'NoneType' is not iterable

File "/home/manthan/mozilla-central/python/mozbuild/mozbuild/build_commands.py", line 82, in build
doing_pgo = 'MOZ_PGO=1' in mozconfig['configure_args']

I tried running ./mach busted and it gives the following output

Bug 1601872 - ./mach build yields TypeError: argument of type 'NoneType' is not iterable
Bug 1601140 - |mach vendor python| wants to remove Python 2 packages from requirements.txt
Bug 1543447 - Multiple minutes to dump a stack from NS_ASSERTION in mochitests and reftests on OS X - Set MOZ_DISABLE_STACK_FIX=1 to disable stack fixer
Bug 1598482 - Missing Taskcluster third_party dependencies make 'mach vendor python' hard to use
Bug 1596422 - ./mach lint does not work on MacOS 10.15 due to Python 3 virtualenv errors
Bug 1597810 - [mozbuild] ./mach configure misbehaves when pyenv is installed on the host
Bug 1597809 - [mozbuild] Pipenv misbehaves, mozbuild/test/configure fails when pyenv is installed on the host
Bug 1597864 - Cannot run mach bootstrap on esr-68
Bug 1597858 - Cannot run mach try on esr-68
Bug 1557535 - clang-format mercurial extension corrupts rebases
Bug 1581684 - Make mach mach completion <command> use the right Python
Bug 1584075 - ImportError: No module named which
Bug 1577908 - Mach driver runs misspelled commands with Python 3 and mach then corrects + executes it
Bug 1522931 - OSX SDK version check doesn't work when using default SDK
Bug 1490802 - mach bootstrap fails on windows with too long path for node module
Bug 1547040 - --try-test-paths isn't respected anymore
Bug 1564201 - mach fails when the objdir contains non-ascii characters
Bug 1556371 - |mach doc | command is not working
Bug 1548948 - |mach install| fails to start x86 emulator

I am sorry but bugzilla isn't the place for support. if you think this is a bug in Firefox build system, please open a new bug
but it seems that you are doing you should not be doing (PGO). Please use an empty .mozconfig to start

where can i get help for this then ?

I have followed that document after which I am getting this error. And yes that is my bug

I have a basic question. How do you check if the code you have written is working correctly?

Product: Firefox Build System → Developer Infrastructure
Severity: minor → S4

hey an outreachy applicant here can i try out this?

(In reply to omega judith from comment #17)

hey an outreachy applicant here can i try out this?

sure, assign it to you and begin working on it.

You need to log in before you can comment on or make changes to this bug.